Skip to content

move ANDROID_APP to bevy_window #15585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2024
Merged

move ANDROID_APP to bevy_window #15585

merged 1 commit into from
Oct 2, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Oct 2, 2024 •
edited
Loading

Objective

Solution

  • the static ANDROID_APP and the android_activity reexport are now in bevy_window

Migration Guide

If you use the android_activity reexport from bevy::winit::android_activity, it is now in bevy::window::android_activity. Same for the ANDROID_APP static

@mockersf mockersf added C-Dependencies A change to the crates that Bevy depends on O-Android Specific to the Android mobile operating system M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Oct 2, 2024
@mockersf mockersf added this to the 0.15 milestone Oct 2, 2024
@alice-i-cecile alice-i-cecile added A-Windowing Platform-agnostic interface layer to run your app in D-Straightforward Simple bug fixes and API improvements, docs, test and examples C-Code-Quality A section of code that is hard to understand or change labels Oct 2, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 2, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 2, 2024
Merged via the queue into bevyengine:main with commit 23b0dd6 Oct 2, 2024
38 checks passed
robtfm pushed a commit to robtfm/bevy that referenced this pull request Oct 4, 2024
@mockersf @robtfm
move ANDROID_APP to bevy_window (bevyengine#15585)
e7826d2 
# Objective

- Remove dependency in bevy_asset to bevy_winit
- First step for bevyengine#15565 

## Solution

- the static `ANDROID_APP` and the `android_activity` reexport are now
in `bevy_window`

## Migration Guide

If you use the `android_activity` reexport from
`bevy::winit::android_activity`, it is now in
`bevy::window::android_activity`. Same for the `ANDROID_APP` static
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@clarfonthey clarfonthey clarfonthey approved these changes

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change C-Dependencies A change to the crates that Bevy depends on D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide O-Android Specific to the Android mobile operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @alice-i-cecile @clarfonthey @BenjaminBrienen