Skip to content

Optimize param validation through new try_get_param #15571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Optimize param validation through new try_get_param #15571

wants to merge 12 commits into from

Conversation

MiniaczQ
Copy link
Contributor

@MiniaczQ MiniaczQ commented Oct 1, 2024

Objective

Fixes #15505

Waiting for #15500, should be merged before this is even finished

Solution

TODO

Testing

TODO

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times S-Blocked This cannot move forward until something else changes labels Oct 1, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 1, 2024
@MiniaczQ MiniaczQ added D-Unsafe Touches with unsafe code in some way D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes labels Oct 1, 2024
@MiniaczQ
Copy link
Contributor Author

MiniaczQ commented Oct 2, 2024

On hold.
It may be possible to use a better solution
https://discord.com/channels/691052431525675048/749335865876021248/1291089012039094303

@MiniaczQ MiniaczQ mentioned this pull request Oct 2, 2024
Closed
@MiniaczQ MiniaczQ changed the title Optimize validate param Optimize param validation through new try_get_param Oct 2, 2024
@MiniaczQ
Copy link
Contributor Author

MiniaczQ commented Oct 3, 2024

Closed in favor of #15606

@MiniaczQ MiniaczQ closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes D-Unsafe Touches with unsafe code in some way S-Blocked This cannot move forward until something else changes
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

Optimize validate_param
2 participants
@MiniaczQ @alice-i-cecile