Skip to content

Migrated NonZero* to NonZero<*> #14978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

Migrated NonZero* to NonZero<*> #14978

merged 1 commit into from
Aug 30, 2024

Conversation

bushrat011899
Copy link
Contributor

Objective

Solution

  • Replace all* instances of NonZero* with NonZero<*>

Testing

  • CI passed locally.

Notes

Within the bevy_reflect implementations for std types, impl_reflect_value!() will continue to use the type aliases instead, as it inappropriately parses the concrete type parameter as a generic argument. If the ZeroablePrimitive trait was stable, or the macro could be modified to accept a finite list of types, then we could fully migrate.

@bushrat011899
Migrated NonZero* to NonZero<*>
b0827b9 
Within the `bevy_reflect` implementations for `std` types, `impl_reflect_value!()` will continue to use the type definitions instead, as it inappropriately parses the concrete type parameter as a generic argument. If the `ZeroablePrimitive` trait was stable, or the macro could be modified to accept a finite list of types, then we could fully migrate.
@alice-i-cecile alice-i-cecile added the A-Math Fundamental domain-agnostic mathematical operations label Aug 29, 2024
@bushrat011899 bushrat011899 added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Cross-Cutting Impacts the entire engine D-Straightforward Simple bug fixes and API improvements, docs, test and examples D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed A-Math Fundamental domain-agnostic mathematical operations labels Aug 29, 2024
@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-Reflection Runtime information about types A-Math Fundamental domain-agnostic mathematical operations and removed C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Cross-Cutting Impacts the entire engine D-Straightforward Simple bug fixes and API improvements, docs, test and examples D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 29, 2024
@alice-i-cecile alice-i-cecile added D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 29, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Aug 29, 2024
lewiszlw
lewiszlw approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@lewiszlw lewiszlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lewiszlw lewiszlw added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 30, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 30, 2024
Merged via the queue into bevyengine:main with commit bc13161 Aug 30, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@lewiszlw lewiszlw lewiszlw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Reflection Runtime information about types C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

Replace NonZero* type usage with NonZero<T> variant
3 participants
@bushrat011899 @alice-i-cecile @lewiszlw