Skip to content

Fix get_handle_path() #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fix get_handle_path() #1290

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5571289
Implement fix
TheRawMeatball Jan 22, 2021
5512371
cargo clippy
TheRawMeatball Jan 23, 2021
95383ac
cargo fmt
TheRawMeatball Jan 23, 2021
286b5f7
Implement fix
TheRawMeatball Jan 22, 2021
2714a80
Merge branch 'get-asset-path-fix' of http://github.com/TheRawMeatball…
TheRawMeatball Jan 26, 2021
29b83a2
Merge remote-tracking branch 'upstream/main' into get-asset-path-fix
TheRawMeatball May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/bevy_asset/src/asset_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,10 @@ impl AssetServer {
}
})
.detach();
asset_path.into()
let owned_path = asset_path.to_owned();
let id: HandleId = asset_path.into();
self.server.handle_to_path.write().insert(id, owned_path);
id
Comment on lines +361 to +364
Copy link
Contributor

@NathanSWard NathanSWard Jun 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as an addition to this, could we add a test to validate this behavior?

}

#[must_use = "not using the returned strong handles may result in the unexpected release of the assets"]
Expand Down