Revert "Implement minimal reflection probes. (#10057)" #11307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 54a943d.
mockersf
added
A-Rendering
cart
approved these changes
Jan 11, 2024
alice-i-cecile
approved these changes
Jan 11, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
I think reflection probes are an important feature that we should try to land, but we need to unbreak CI (and not ship bugs).
alice-i-cecile
added
the
S-Ready-For-Final-Review
Contributor
|
Fix for reflection probes should be pretty simple. I believe we just need to add a check if the render device supports the texture binding array feature, rather than a conditional cfg for non wasm platforms. |
Ixentus
pushed a commit
to Ixentus/bevy
that referenced
this pull request
Jan 12, 2024
…yengine#11307) # Objective - Fix working on macOS, iOS, Android on main - Fixes bevyengine#11281 - Fixes bevyengine#11282 - Fixes bevyengine#11283 - Fixes bevyengine#11299 ## Solution - Revert bevyengine#10057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution