Add dedicated component for specifying draw order in 2D #10293
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Move away from basing draw order on global Z translation in 2D.
Solution
Add a new
Sorting
component to control the draw order of 2D entities.This solves the issues of scale on the Z axis and rotation on the X and Y axes affecting the draw order of child entities.
Closes #4149
We could later expand this component with desired features like sorting groups or y-sort.
This PR should (probably) be consider together with #8268.
Benchmark
I've tried to benchmark the following command but I was getting very inconsistent results.
cargo run --release --example bevymark -- --waves 1 --per-wave 50000 --benchmark
I now seem to be getting consistent results again that show a large improvement from this PR, but quite frankly I have no idea why that would be, so I don't trust it :v
Probably something to do with my machine/os.
It would be great if someone could run this benchmark on their own machine to verify :)
Changelog
Added
Sorting
andComputedSorting
components.TODO