wireframes: workaround for DX12 #10022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IceSentry could you check if this PR fixes the issue? |
mockersf
added
A-Rendering
|
It does seem to work. Although, I think if we used my PR that uses Material for wireframes we could just use the default vertex shader and not have this issue I think. I'll need to test it but for now we should probably merge this PR in the meantime. (#5314) Edit: I tested removing the vertex shader in the wireframe material PR and it worked perfectly. |
IceSentry
approved these changes
Oct 4, 2023
alice-i-cecile
approved these changes
Oct 4, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
regnarock
pushed a commit
to regnarock/bevy
that referenced
this pull request
Oct 13, 2023
# Objective - Fixes bevyengine#10019 ## Solution - Uses a workaround for DX12
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
# Objective - Fixes bevyengine#10019 ## Solution - Uses a workaround for DX12
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - Fixes bevyengine#10019 ## Solution - Uses a workaround for DX12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution