Adapter: Minor fixes and more thorough testing #317
Merged
+67
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The deserialize call for `kwargs` was missing. * The constructor can be (de)serialized using get_registered_name and get_registered_object Added meaningful error message, if functions are not registered and not passed as custom objects.
Keras deserializes tuples as lists. This can cause problems, and has to be undone manually.
* also, expand test to ensure consistency of outputs before and after serialization
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the tests for the
Adapterand fixes some problems encountered in those tests:LambdaTransformand allows serialization of the transform_constructor, 4839fd6