-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add VonMises family #453
add VonMises family #453
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -241,6 +241,7 @@ def build(self, nu, invlinks): | |
nu = tt.concatenate([np.zeros((data.shape[0], 1)), nu], axis=1) | ||
|
||
# Add mean parameter and observed data | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. was this added on purpose? Otherwise, I would remove it, so the format is the same in all the code. |
||
kwargs = {self.family.likelihood.parent: linkinv(nu), "observed": data} | ||
|
||
# Add auxiliary parameters | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,6 +63,7 @@ class Family: | |
"logit", | ||
"probit", | ||
"softmax", | ||
"tan_2", | ||
] | ||
|
||
def __init__(self, name, likelihood, link): | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ | |
"NegativeBinomial": {"params": ("mu", "alpha"), "parent": "mu", "args": ("alpha",)}, | ||
"Poisson": {"params": ("mu",), "parent": "mu", "args": None}, | ||
"StudentT": {"params": ("mu", "sigma"), "args": ("sigma", "nu")}, | ||
"Vonmises": {"params": ("mu", "kappa"), "parent": "mu", "args": ("kappa",)}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be |
||
"Wald": {"params": ("mu", "lam"), "parent": "mu", "args": ("lam",)}, | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this a regular function? We're still not using any pickling but this can be an impediment. See #400.