add VonMises family #453
Merged
add VonMises family #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 89.43% 89.18% -0.25%
==========================================
Files 31 31
Lines 2442 2460 +18
==========================================
+ Hits 2184 2194 +10
- Misses 258 266 +8
Continue to review full report at Codecov.
|
tomicapretto
requested changes
Feb 17, 2022
bambi/backend/pymc.py
Outdated
| @@ -25,6 +25,7 @@ class PyMC3Model: | |||
| "log": tt.exp, | |||
| "logit": logit, | |||
| "probit": probit, | |||
| "tan_2": lambda x: 2 * tt.arctan(x), | |||
There was a problem hiding this comment.
Can we make this a regular function? We're still not using any pickling but this can be an impediment. See #400.
bambi/families/likelihood.py
Outdated
| @@ -11,6 +11,7 @@ | |||
| "NegativeBinomial": {"params": ("mu", "alpha"), "parent": "mu", "args": ("alpha",)}, | |||
| "Poisson": {"params": ("mu",), "parent": "mu", "args": None}, | |||
| "StudentT": {"params": ("mu", "sigma"), "args": ("sigma", "nu")}, | |||
| "Vonmises": {"params": ("mu", "kappa"), "parent": "mu", "args": ("kappa",)}, | |||
There was a problem hiding this comment.
This should be "VonMises" with capital M, as in the PyMC distribution name.
bambi/backend/terms.py
Outdated
| @@ -241,6 +241,7 @@ def build(self, nu, invlinks): | |||
| nu = tt.concatenate([np.zeros((data.shape[0], 1)), nu], axis=1) | |||
|
|
|||
| # Add mean parameter and observed data | |||
|
|
|||
There was a problem hiding this comment.
was this added on purpose? Otherwise, I would remove it, so the format is the same in all the code.
tomicapretto
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to perform regression on circular response variables.