Add using cached-permissions and cached-permissions-path CLI features #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxu2-atlassian
force-pushed
the
feat/EAS-2415
branch
2 times, most recently
from
aa03a01 to
e7697b7
Compare
jwong101
requested changes
Mar 13, 2025
|
|
||
| const CACHE_EXPIRATION: Duration = Duration::from_secs(60 * 60 * 24 * 7); // 1 week | ||
|
|
||
| fn default_cache_path() -> PathBuf { |
There was a problem hiding this comment.
If $HOME isn't set, then we probably shouldn't use the default path.
| if duration < self.config.ttl { | ||
| return true; | ||
| } else { | ||
| println!( |
There was a problem hiding this comment.
These should output to stderr, since it will clutter the output if someone redirects fsrt's output to a file or program.
dxu2-atlassian
force-pushed
the
feat/EAS-2415
branch
from
e7697b7 to
c867e12
Compare
dxu2-atlassian
force-pushed
the
feat/EAS-2415
branch
from
c867e12 to
2c826f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the feature to enable the user to use previously cached permission mappings to decrease the runtime. Also has a feature to enable the user to designate where the cache files should be stored, otherwise will use defaults. Documentation is also updated.