Change for clippy + README + stderr

Author: dxu2-atlassian

README.md

@@ -16,15 +16,15 @@ Arguments:
 
   Options:
     -d, --debug
-        --dump-ir <DUMP_IR>           Dump the IR for the specified function
-    -dt, --dump-dt <DUMP_DOM_TREE>    Dump the Dominator Tree for the specified app
-    -f, --function <FUNCTION>         A specific function to scan, must be an entrypoint specified in `manifest.yml`
-    -h, --help                        Print help information
-    -V, --version                     Print version information
-    --check-permissions               Runs the permission checker
-    --cached-permissions              Uses cached swagger permissions to avoid redownloading them
-    --cached-permissions-path         User designated cache location, if not specified defaults to ~/.cache 
-    --graphql-schema-path <LOCATION>  Uses the graphql schema in location; othwerwise selects ~/.config dir  
+        --dump-ir <DUMP_IR>                 Dump the IR for the specified function
+    -dt, --dump-dt <DUMP_DOM_TREE>          Dump the Dominator Tree for the specified app
+    -f, --function <FUNCTION>               A specific function to scan, must be an entrypoint specified in `manifest.yml`
+    -h, --help                              Print help information
+    -V, --version                           Print version information
+    --check-permissions                     Runs the permission checker
+    --cached-permissions                    Uses cached swagger permissions to avoid redownloading them
+    --cached-permissions-path <LOCATION>    Uses the designated cache location, otherwise selects ~/.cache dir 
+    --graphql-schema-path <LOCATION>        Uses the graphql schema in location; othwerwise selects ~/.config dir  
 ```
 
 ## Installation

crates/forge_permission_resolver/src/permissions_cache.rs

@@ -13,8 +13,11 @@ use tracing::debug;
 const CACHE_EXPIRATION: Duration = Duration::from_secs(60 * 60 * 24 * 7); // 1 week
 
 fn default_cache_path() -> PathBuf {
-    let home = env::var("HOME").unwrap_or_else(|_| ".".to_string());
-    PathBuf::from(home).join(".cache/fsrt")
+    if let Ok(home) = env::var("HOME") {
+        PathBuf::from(home).join(".cache/fsrt")
+    } else {
+        PathBuf::new()
+    }
 }
 
 /// Struct to hold cache-related settings
@@ -65,19 +68,19 @@ impl PermissionsCache {
                     if duration < self.config.ttl {
                         return true;
                     } else {
-                        println!(
+                        eprintln!(
                             "Cache file expired: {:?}, duration {:?} is greater than ttl {:?}",
                             path, duration, self.config.ttl
                         );
                     }
                 } else {
-                    println!("Failed to get elapsed time for cache file: {:?}", path);
+                    eprintln!("Failed to get elapsed time for cache file: {:?}", path);
                 }
             } else {
-                println!("Failed to get modified time for cache file: {:?}", path);
+                eprintln!("Failed to get modified time for cache file: {:?}", path);
             }
         } else {
-            println!("Failed to get metadata for cache file: {:?}", path);
+            eprintln!("Failed to get metadata for cache file: {:?}", path);
         }
         false
     }

crates/forge_permission_resolver/src/serde.rs

@@ -26,20 +26,14 @@ impl From<SerializablePermissionHashMap> for PermissionHashMap {
         let deserialized_map: PermissionHashMap = serialized
             .map
             .into_iter()
-            .filter_map(|(key, v)| {
+            .map(|(key, v)| {
                 let mut parts = key.split("::");
-                let url = parts.next();
-                let req = parts.next();
-                if let (Some(url), Some(req)) = (url, req) {
-                    match req.parse::<RequestType>() {
-                        Ok(req_type) => Some(((url.to_string(), req_type), v)),
-                        Err(_) => {
-                            panic!("Failed to parse RequestType from: {}", req);
-                        }
-                    }
-                } else {
-                    panic!("Failed to split key: {}", key);
-                }
+                let url = parts.next().expect("Failed to split key");
+                let req = parts.next().expect("Failed to split key");
+                let req_type = req
+                    .parse::<RequestType>()
+                    .expect("Failed to parse RequestType");
+                ((url.to_string(), req_type), v)
             })
             .collect();
         deserialized_map