Skip to content

refactor: align pnpm package store with lockfile #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Apr 21, 2025

Fixes issues such as:


Changes are visible to end-users: yes/no

  • Searched for relevant documentation and updated as needed: yes/no
  • Breaking change (forces users to change their own code or config): yes/no
  • Suggested release notes appear below: yes/no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

Copy link

aspect-workflows bot commented Apr 21, 2025

Test

All tests were cache hits

225 tests (100.0%) were fully cached saving 32s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 534ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 214ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 15s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 699ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 822ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 268ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 603ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 97ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 450ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

43 tests (100.0%) were fully cached saving 3s.


Test

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 2s.


Test

e2e/repo_mapping

⚠️ Buildkite build #8394 failed.

//:e2e/lib-package_store_entry failed to build

in output_files rule //:e2e/lib-package_store_entry:
Traceback (most recent call last):
	File
"/mnt/ephemeral/output/rules_js/e2e_repo_mapping/external/aspect_bazel_lib~/lib/private/output_files.bzl",
line 29, column 17, in _output_files
		fail(msg)
Error in fail: node_modules/.aspect_rules_js/@[email protected]/node_modules/@e2e/lib file not found within the
DefaultInfo of <target //:node_modules/@e2e/lib>

💡 To reproduce the build failures, run

bazel build //:e2e/lib-package_store_entry

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 126ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 173ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 99ms.


Buildifier      Format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant