-
-
Notifications
You must be signed in to change notification settings - Fork 131
fix: pnpm v9 url version specifiers without resolved semver #2209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
version: link:../b | ||
'@scoped/c': | ||
specifier: file:../c | ||
version: file:../projects/c(@scoped/b@projects+b) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice the file:
and (..peers..)
here. That causes a bug as soon as @scope/c
is used with different peers (such as none).
This is fixed in #2177
version: https://gitpkg.vercel.app/EqualMa/gitpkg-hello/packages/hello | ||
jsonify: | ||
specifier: https://github.com/aspect-build/test-packages/releases/download/0.0.0/@foo-jsonify-0.0.0.tgz | ||
version: '@foo/jsonify@https://github.com/aspect-build/test-packages/releases/download/0.0.0/@foo-jsonify-0.0.0.tgz' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice the ://
here. This shows a difference in v9+ where the version being a URL prefixes the pkgname@
unlike <v9.
This is what required the new replace("://", "/")
(which I didn't realize was in this cherry-pick 😅)
A similar test found an issue involving
file:
deps + peers, but I'd like to merge this first.Changes are visible to end-users: no
Test plan