Skip to content

perf: avoid per-node closure allocation in operator-chain checks #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 2 commits into from
+7 −2
Closed

perf: avoid per-node closure allocation in operator-chain checks #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c8e836
perf: avoid per-node closure allocation in operator-chain checks
github-actions[bot] Sep 1, 2026
0f5b537
Merge remote-tracking branch 'origin/main' into repo-assist/perf-avoi…
Copilot Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/metricsAnalyzer/languages/csharpAnalyzer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ export class CSharpMetricsAnalyzer {
private nesting = 0;
/** Depth of preprocessor block nesting (preproc_if / preproc_else etc.) during traversal */
private preprocessorDepth = 0;

/**
* Caches the { increment, reason } pair computed by the ERROR-node / malformed-declaration
* heuristics, keyed by the node they were computed for. `visit()` always calls
Expand Down
8 changes: 7 additions & 1 deletion src/metricsAnalyzer/languages/pythonAnalyzer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ export class PythonMetricsAnalyzer {

/** Current nesting level during analysis */
private nesting = 0;
/**
* Bound reference to `getBooleanOperator`, created once per instance instead of as a new
* arrow-function closure on every `isOutermostInSameOperatorChain` call.
*/
private readonly getBooleanOperatorBound = (n: Parser.SyntaxNode): string | null =>
this.getBooleanOperator(n);
/** Current complexity score during analysis */
private complexity = 0;
/** Array of complexity details for the current function being analyzed */
Expand Down Expand Up @@ -297,7 +303,7 @@ export class PythonMetricsAnalyzer {
if (op === "and" || op === "or") {
// Only count the outermost node in a same-operator chain.
// e.g. `a and b and c` has two boolean_operators, but counts once.
if (isOutermostInSameOperatorChain(node, op, "boolean_operator", (n) => this.getBooleanOperator(n))) {
if (isOutermostInSameOperatorChain(node, op, "boolean_operator", this.getBooleanOperatorBound)) {
return 1 + this.nesting;
}
return 0; // inner node of a same-operator chain — already counted by parent
Expand Down
Loading