perf: avoid per-node closure allocation in operator-chain checks

[github-actions]

🤖 This is an automated pull request from Repo Assist, an AI assistant. A human maintainer should review before merging.

What

Across all five binary/boolean-operator-chain analyzers (csharpAnalyzer.ts, goAnalyzer.ts, javaAnalyzer.ts, pythonAnalyzer.ts, rustAnalyzer.ts), getComplexityIncrement()/getComplexityReason() called isOutermostInSameOperatorChain(node, operator, kind, (n) => this.getBinaryOperator(n)), passing a brand-new arrow-function closure as the predicate on every single logical-operator node (&&, ||, and, or) encountered during AST traversal.

Since isOutermostInSameOperatorChain walks up the parent chain checking the predicate against each ancestor, this closure was being allocated repeatedly per call, adding avoidable garbage-collection pressure on files with many logical operators.

Fix

Each analyzer now creates a single bound reference (e.g. getBinaryOperatorBound) once per class instance as a readonly arrow-function field, and reuses it at every call site instead of allocating a fresh closure each time. This is a mechanical, behavior-preserving change — no logic changed, only where the closure is created.

Trade-offs

• Adds one small field per analyzer class; negligible memory cost, offset by removing a much more frequent per-call allocation.
• Purely internal refactor — no public API or output changes.

Test Status

• npm run compile ✅ passes
• npm run lint ✅ passes
• npm run test:coverage ✅ 241/241 tests passing, coverage 98.78% stmts / 95.16% branches / 99.14% funcs / 98.78% lines (all above configured thresholds)

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• releaseassets.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "releaseassets.githubusercontent.com"

See Network Configuration for more information.

Generated by 🌈 Repo Assist, see workflow run. Learn more.
_{Comment /repo-assist to run again}

_{Add this agentic workflow to your repo}

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@42c2ab5b4e4c9273534c39259b2e0df7f20f07e9

[askpt]

@copilot resolve the merge conflicts in this pull request

[Copilot]

@copilot resolve the merge conflicts in this pull request

Conflicts are resolved. I merged origin/main into this branch and finalized it in commit 0f5b537.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.20%. Comparing base (ebe1a46) to head (0f5b537).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   98.19%   98.20%           
=======================================
  Files          12       12           
  Lines        3885     3890    +5     
  Branches      440      440           
=======================================
+ Hits         3815     3820    +5     
  Misses         70       70           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

🟡 Changes recommended

The equivalent per-node callback allocation remains in the JS-like analyzer, and the PR description misstates the scope.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Optimizes Python boolean-chain analysis by reusing a callback closure per analyzer instance.

Changes:

• Adds a reusable Python operator callback.
• Removes a blank line from the C# analyzer.
• PR description overstates the changed scope.

File summaries

File	Description
src/metricsAnalyzer/languages/pythonAnalyzer.ts	Reuses the operator callback. The equivalent hot-path allocation remains in jsLikeAnalyzer.ts.
src/metricsAnalyzer/languages/csharpAnalyzer.ts	Removes an unrelated blank line only.

Review details

Suppressed comments (1)

src/metricsAnalyzer/languages/pythonAnalyzer.ts:95

• The PR description says all five analyzers now add per-instance bound fields, but this diff only adds one for Python; C#, Go, Java, and Rust already pass the shared getBinaryLogicalOperator, and the only C# change is whitespace. Please update the What/Fix sections and changed-file scope so reviewers are not led to expect four code changes that are absent from this PR.

  private readonly getBooleanOperatorBound = (n: Parser.SyntaxNode): string | null =>
    this.getBooleanOperator(n);

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

🤖 This is an automated response from Repo Assist.

Revisiting this PR since it keeps falling behind main and needing rebases.

This PR is now superseded. The closure-allocation goal it set out to solve was independently achieved by PR #597 ("refactor: extract shared getBinaryLogicalOperator helper", merged 2026-09-02), which moved the operator-detection logic to a shared top-level function in complexityHelpers.ts used by all five analyzers (C#, Go, Java, Python, Rust) — eliminating the per-node closure allocation without needing the getBinaryOperatorBound bound-method fields this PR introduces.

I attempted a rebase onto current main and confirmed the conflicts stem entirely from this overlap: main already replaced this.getBinaryOperator(node) calls with the shared getBinaryLogicalOperator(node) function everywhere this PR touches.

Recommendation: close this PR as superseded by #597 — no further action needed from Repo Assist here. Thanks for the review effort on this one!

Generated by 🌈 Repo Assist, see workflow run. Learn more.
_{Comment /repo-assist to run again}

_{Add this agentic workflow to your repo}

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@42c2ab5b4e4c9273534c39259b2e0df7f20f07e9