-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Make serial plotter ringbuffer size configurable #7454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Make serial plotter ringbuffer size configurable #7454
Conversation
@ArduinoBot build this please |
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7454-BUILD-747-linux32.tar.xz ℹ️ The |
Just a note for others, and to stop myself from keep opening this issue: The PR (I think this should have been in the description):
However, the quality check fails, because there is:
Both of these should be trivial to fix, but are there any maintainer (person with write access) that would be willing to merge this change? |
So, does #7461 actually contain all the code in this issue as well? |
do not modify parameter in setNewBufferCapacity
Do not pull it yet. I have made faulty merge. |
This partially fixes arduino/arduino-serial-plotter-webapp#29 (and the remaining part may be wontfix) |
Wilhelm Wiens seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
No description provided.