Skip to content

Add clean button to SerialPlot #7422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add clean button to SerialPlot #7422

wants to merge 4 commits into from

Conversation

chromhelm
Copy link
Contributor

No description provided.

chromhelm and others added 4 commits May 29, 2015 16:51
@chromhelm
- Saving same bytes in HardwareSerial::write
f8db03e
@chromhelm
Merge branch 'master' of https://github.com/Arduino/Arduino
d89ffe2
@chromhelm
Add clear button to SerialPlotter
219cc6c
@chromhelm
Added label support to SerialPlotter
c76a8f9 
Supports csv style header and colon separated <label>:<value>
Two command where added. All command start with #
CLEAN ->  will clean the scope
SIZE:<value> -> set the xaxis size. Right now it is limited to 10-5000.
@chromhelm chromhelm mentioned this pull request Apr 5, 2018
Closed
@facchinm
Copy link
Member

Hi @chromhelm ,
thanks for the contribution! Could you cleanup it a bit?
Since you implement three functionalities (clear button, labels and configurable buffer) it would be better to have three different commits, hence removing f8db03e from the history and splitting c76a8f9 into two (or more) commits.

@facchinm facchinm added Component: IDE user interface The Arduino IDE's user interface Component: IDE Serial monitor Tools > Serial Monitor labels Apr 10, 2018
facchinm
facchinm reviewed Apr 10, 2018
View reviewed changes
app/src/processing/app/SerialPlotter.java
String label = null;

// all commands start with #
if(parts[i].startsWith("#") && parts[i].length() > 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of hardcoded commands but I appreciate the idea.
Probably a standalone commit (like "add CLEAR and SET_SIZE runtime commands to Serial Plotter") could do the trick and make discussion easier

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in pull request #7461

@chromhelm chromhelm closed this Apr 10, 2018
@chromhelm
Copy link
Contributor Author

Hi
I made a new pull request for label implementation #7453

@per1234 per1234 added the SerialPlotter Tools > Serial Plotter label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm facchinm left review comments

Assignees
No one assigned
Labels
Component: IDE Serial monitor Tools > Serial Monitor Component: IDE user interface The Arduino IDE's user interface SerialPlotter Tools > Serial Plotter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chromhelm @facchinm @per1234