-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control API Architecture #63
Conversation
5061d9e
to
381d33e
Compare
docs/modules/ROOT/pages/references/architecture/control-api-org.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-org.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-org.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-org.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-org.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-zone.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-org.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-team.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-zone.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sync between Keycloak and an APPUiO Cloud Zone is based on the user name. This architecture now uses the users UUID. While this solves the issue of namespace name uniquenss (no need to prefix), it introduces a cognitive disconect for the users (one system uses username the other uses UUID). I would prefer to stick with username and accept the need for prefexing.
If we use the username in a metadata.name for namespaces, it will impose a limit to what usernames are possible. We would need to verify that usernames are matching a-z and no certain special characters (https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names). We couldn't use email addresses as usernames for example since they contain As ugly as it is, we can't just take the username verbatim and prefix it. |
476e385
to
bcb55aa
Compare
docs/modules/ROOT/pages/references/architecture/control-api-team.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-team.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-team.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I object against having two conflicting documentations in paralell. While it seems more complicated, I understand and agree with user being a global resource with all those roles and rolebindings (does this work as expected/was this tested?).
As written in the internal chat, the idea is to delete the page which doesn't reflect our proposal. It's only here to have both options during discussions. Before it gets merged, a cleanup will be done.
Testing currently ongoing, but by-the-docs it should ™️ work. |
docs/modules/ROOT/pages/references/architecture/control-api-org.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-zone.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/references/architecture/control-api-user.adoc
Outdated
Show resolved
Hide resolved
f6ba3a6
to
910f054
Compare
Checklist
change
,decision
,requirement/quality
,requirement/functional
,dependency
as they show up in the changelog