Add a clusterpolicy to set default for .spec.activeDeadlineSeconds
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
feat/runonce-activedeadlineseconds
branch
2 times, most recently
from
76b82b9 to
45ce3b4
Compare
Create a new cluster policy which ensures that `.spec.activeDeadlineSeconds` is set on all "runonce" pods (pods with `.spec.restartPolicy` set to "OnFailure" or "Never"). This policy doesn't modify "runonce" pods which already have `.spec.activeDeadlineSeconds` set. All other "runonce" pods are configured with the global default activeDeadlineSeconds value extracted from component parameter `runOnceActiveDeadlineSeconds.defaultActiveDeadlineSeconds`. Users can override the default value on individual namespaces by setting annotation with key `runOnceActiveDeadlineSeconds.overrideAnnotationKey` to the desired default value for pods in that namespace.
simu
force-pushed
the
feat/runonce-activedeadlineseconds
branch
from
45ce3b4 to
fad04e6
Compare
simu
changed the title
.spec.activeDeadlineSeconds.spec.activeDeadlineSeconds
corvus-ch
approved these changes
Nov 3, 2021
glrf
suggested changes
Nov 3, 2021
* Default `.metadata.annotations` to the empty object if it's null * Default to the global default activeDeadlineSeconds if annotation cannot be parsed as a number. Co-authored-by: Fabian Fischer <[email protected]>
simu
force-pushed
the
feat/runonce-activedeadlineseconds
branch
from
78ff0b8 to
f7d3b34
Compare
glrf
approved these changes
Nov 3, 2021
corvus-ch
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new cluster policy which ensures that
.spec.activeDeadlineSecondsis set on all "runonce" pods (pods with.spec.restartPolicyset to "OnFailure" or "Never").This policy doesn't modify "runonce" pods which already have
.spec.activeDeadlineSecondsset.All other "runonce" pods are configured with the global default activeDeadlineSeconds value extracted from component parameter
runOnceActiveDeadlineSeconds.defaultActiveDeadlineSeconds.Users can override the default value on individual namespaces by setting annotation with key
runOnceActiveDeadlineSeconds.overrideAnnotationKeyto the desired default value for pods in that namespace.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog