fix: ToLower/ToUpper to ToLowerInvariant/ToUpperInvariant #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dor-bl
reviewed
Mar 12, 2025
|
Added extra spaces/tabs to not have diff |
Dor-bl
reviewed
Mar 12, 2025
| @@ -27,7 +27,7 @@ public static class ScreenOrientationExtensions | |||
| /// <param name="orientation"></param> | |||
| /// <returns></returns> | |||
| public static string JSONWireProtocolString(this ScreenOrientation orientation) => | |||
| orientation.ToString().ToUpper(); | |||
| orientation.ToString().ToUpperInvariant(); | |||
There was a problem hiding this comment.
I tested the enum to string conversion on my local with ToUpperInvariant, while my env didn't cause the #920, so it tested the output didn't change with ToUpper though
There was a problem hiding this comment.
Pull Request Overview
This PR fixes locale-dependent string casing in various parts of the .NET client by replacing ToLower/ToUpper with their invariant counterparts.
- Replaces ToLower with ToLowerInvariant in capability parsing and environment evaluation
- Updates screen recording and orientation options to use invariant casing conversions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Appium.Net/Appium/Service/Options/OptionCollector.cs | Updated boolean value conversion for capabilities using ToLowerInvariant |
| test/integration/helpers/Env.cs | Adjusted environment variable conversion to use ToLowerInvariant |
| src/Appium.Net/Appium/iOS/IOSStartScreenRecordingOptions.cs | Changed video type/quality conversion to ToLowerInvariant |
| src/Appium.Net/Appium/ScreenOrientationExtensions.cs | Replaced ToUpper with ToUpperInvariant for consistent casing |
Dor-bl
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
I've learned in #920, we should use
ToLowerInvariant/ToUpperInvariantto avoid host machine language config in the string conversion. This PR applies the same change what #920 does for clipboard for others.Types of changes
What types of changes are you proposing/introducing to the .NET client?
Put an
xin the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Please provide more details about changes if necessary. You can provide code samples showing how they work and possible use cases if there are new features. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub