fix: ToLower/ToUpper to ToLowerInvariant/ToUpperInvariant (#921)

* fix: ToLower/ToUpper to ToLowerInvariant/ToUpperInvariant

* keep extra spaces

* remove automatic new line by GH

* remove new line by GitHub editor

* keep extra tab

* keep extra space

* keep extra spaces/tabs more

* last extra space

Author: KazuCocoa

src/Appium.Net/Appium/ScreenOrientationExtensions.cs

@@ -27,7 +27,7 @@ public static class ScreenOrientationExtensions
         /// <param name="orientation"></param>
         /// <returns></returns>
         public static string JSONWireProtocolString(this ScreenOrientation orientation) =>
-            orientation.ToString().ToUpper();
+            orientation.ToString().ToUpperInvariant();
 
         /// <summary>
         /// Converts the string to a screen orientation if possible, else throws ArgumentOutOfRangeException 

src/Appium.Net/Appium/Service/Options/OptionCollector.cs

@@ -107,7 +107,7 @@ private string ParseCapabilitiesIfWindows()
                     {
                         if (typeof(bool).IsAssignableFrom(value.GetType()))
                         {
-                            value = Convert.ToString(value).ToLower();
+                            value = Convert.ToString(value).ToLowerInvariant();
                         }
                     }
 
@@ -153,7 +153,7 @@ private string ParseCapabilitiesIfUNIX()
                     {
                         if (typeof(bool).IsAssignableFrom(value.GetType()))
                         {
-                            value = Convert.ToString(value).ToLower();
+                            value = Convert.ToString(value).ToLowerInvariant();
                         }
                     }
 

src/Appium.Net/Appium/iOS/IOSStartScreenRecordingOptions.cs

@@ -24,7 +24,7 @@ public enum VideoType
         /// <returns>self instance for chaining.</returns>
         public IOSStartScreenRecordingOptions WithVideoType(VideoType videoType)
         {
-            Parameters["videoType"] = videoType.ToString().ToLower();
+            Parameters["videoType"] = videoType.ToString().ToLowerInvariant();
             return this;
         }
 
@@ -54,7 +54,7 @@ public enum VideoQuality
         /// <returns></returns>
         public IOSStartScreenRecordingOptions WithVideoQuality(VideoQuality videoQuality)
         {
-            Parameters["videoQuality"] = videoQuality.ToString().ToLower();
+            Parameters["videoQuality"] = videoQuality.ToString().ToLowerInvariant();
             return this;
         }
 

test/integration/helpers/Env.cs

@@ -49,7 +49,7 @@ private static void Init()
 
         private static bool IsTrue(object val)
         {
-            val = val?.ToString().ToLower().Trim();
+            val = val?.ToString().ToLowerInvariant().Trim();
             return val.Equals("true") || val.Equals("1");
         }