Skip to content

Add OpenSSL cipher operator tests #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sainadh777 wants to merge 1 commit into
base: main
Choose a base branch
from
+36 −11
Draft

Add OpenSSL cipher operator tests #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,16 +902,6 @@ These are bugs, correctness issues, or missing functionality that may affect pro

---

### 81. OpenSSL Cipher Test Coverage (1 item)

| # | File:Line | Description | Fix Idea | Effort | Difficulty |
|---|-----------|-------------|----------|--------|------------|
| 81.1 | `TestOpenSSLCipherConfigurationParser.java:497` | Individual operator tests missing | Add unit tests for each cipher string operator: `+`, `-`, `!`, `@`, colon separator, etc. | 1-2 days | Medium |

**Total estimated effort: 1-2 days, Medium difficulty**

---

### 82. OCSP Test Hardcoded Serials (1 item)

| # | File:Line | Description | Fix Idea | Effort | Difficulty |
Expand Down
37 changes: 36 additions & 1 deletion test/org/apache/tomcat/util/net/openssl/ciphers/TestOpenSSLCipherConfigurationParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,42 @@ public void testCBC() throws Exception {
}


// TODO: Add tests for the individual operators
@Test
public void testOperatorExclude() throws Exception {
testSpecification("AES128:!SHA256:SHA256");
}


@Test
public void testOperatorDelete() throws Exception {
testSpecification("AES128:-SHA256:SHA256");
}


@Test
public void testOperatorMoveToEnd() throws Exception {
testSpecification("AES128:AES256:+AES128");
}


@Test
public void testOperatorIntersection() throws Exception {
testSpecification("AES128+SHA256");
}


@Test
public void testOperatorStrengthSort() throws Exception {
testSpecification("AES128:AES256:@STRENGTH");
}


@Test
public void testSeparators() throws Exception {
testSpecification("AES128:AES256");
testSpecification("AES128,AES256");
testSpecification("AES128 AES256");
}

@Test
public void testSpecification01() throws Exception {
Expand Down