Add OpenSSL cipher operator tests - #1063
Draft
sainadh777 wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
@markt-asf, when you have a chance, could you review this test-only change? You are the primary contributor to this cipher parser test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!,-,+, intersection, and@STRENGTHRationale
The parser integration test compared a number of compound expressions with the installed OpenSSL implementation, but it did not isolate each operator. These focused cases make regressions in exclusion, deletion/re-addition, ordering, intersection, strength sorting, and separator handling easier to identify.
Impact
Test-only change. There is no runtime behavior or public API change, so no changelog entry is included.
Validation
Environment: Ubuntu 22.04 container on Linux 6.8 (aarch64), Eclipse Temurin 21.0.12, Ant 1.10.12, OpenSSL 3.0.2.
ant -Dbase.path=/workspace-cache -Dexecute.validate=true validateBUILD SUCCESSFUL; Checkstyle 14.1.0 checked 7,685 files.ant -Dbase.path=/workspace-cache -Dtest.entry=org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser testBUILD SUCCESSFUL; 79 tests, 0 failures, 0 errors, 0 skipped.ant -Dbase.path=/workspace-cache cleanBUILD SUCCESSFUL.ant -Dbase.path=/workspace-cacheBUILD SUCCESSFUL(clean source/distribution build).ant -Dbase.path=/workspace-cache teston a macOS-backed container bind mountTestGroupChannelMemberArrival:BUILD SUCCESSFUL(32s).TestDirResourceSetReadOnly:BUILD SUCCESSFUL(3s).TestChunkedInputFilter:BUILD SUCCESSFUL(29s).TestHttp2Section_6_8:BUILD SUCCESSFUL(29s).TestWsWebSocketContainerTimeoutClient:BUILD SUCCESSFUL(14s).ant -Dbase.path=/workspace-cache testBUILD SUCCESSFULin 99m38s; 652 suites, 41,327 tests, 0 failures, 0 errors, 330 skipped./linux-workspace/output/build, received HTTP 200 fromhttp://127.0.0.1:8080/, accepted the shutdown command, exited with status 0, and was reaped cleanly.The two tested source files were SHA-256 matched byte-for-byte to commit
d6d450fd9b938b95a397fa4a957b573c07e74af2before pushing.