Skip to content

Remove postgres_latest as image tag #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion getting-started/assets/cloud_providers/deploy-aws.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ aws s3api create-bucket --bucket $S3_BUCKET_NAME --region $CURRENT_REGION --crea
export STORAGE_LOCATION="s3://$S3_BUCKET_NAME/quickstart_catalog/"

./gradlew clean :polaris-server:assemble :polaris-admin:assemble \
-Dquarkus.container-image.tag=postgres-latest \
-Dquarkus.container-image.build=true \
--no-build-cache

Expand Down
1 change: 0 additions & 1 deletion getting-started/assets/cloud_providers/deploy-azure.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ azure.auth-type=DEFAULT
EOF

./gradlew clean :polaris-server:assemble :polaris-admin:assemble \
-Dquarkus.container-image.tag=postgres-latest \
-Dquarkus.container-image.build=true \
--no-build-cache

Expand Down
1 change: 0 additions & 1 deletion getting-started/assets/cloud_providers/deploy-gcp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ gcloud storage buckets create "gs://$GCS_BUCKET_NAME" --location=$CURRENT_REGION
export STORAGE_LOCATION="gs://$GCS_BUCKET_NAME/quickstart_catalog/"

./gradlew clean :polaris-server:assemble :polaris-admin:assemble \
-Dquarkus.container-image.tag=postgres-latest \
-Dquarkus.container-image.build=true \
--no-build-cache

Expand Down
1 change: 0 additions & 1 deletion getting-started/eclipselink/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ This example requires `jq` to be installed on your machine.
:polaris-server:quarkusAppPartsBuild --rerun \
:polaris-admin:assemble \
:polaris-admin:quarkusAppPartsBuild --rerun \
-Dquarkus.container-image.tag=postgres-latest \
-Dquarkus.container-image.build=true
```

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
services:
polaris-bootstrap:
# IMPORTANT: the image MUST contain the Postgres JDBC driver and EclipseLink dependencies, see README for instructions
image: apache/polaris-admin-tool:postgres-latest
image: apache/polaris-admin-tool:latest
environment:
polaris.persistence.type: eclipse-link
polaris.persistence.eclipselink.configuration-file: /deployments/config/eclipselink/persistence.xml
Expand Down
2 changes: 1 addition & 1 deletion getting-started/eclipselink/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ services:

polaris:
# IMPORTANT: the image MUST contain the Postgres JDBC driver and EclipseLink dependencies, see README for instructions
image: apache/polaris:postgres-latest
image: apache/polaris:latest
ports:
# API port
- "8181:8181"
Expand Down
1 change: 0 additions & 1 deletion getting-started/jdbc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ This example requires `jq` to be installed on your machine.
:polaris-server:quarkusAppPartsBuild --rerun \
:polaris-admin:assemble \
:polaris-admin:quarkusAppPartsBuild --rerun \
-Dquarkus.container-image.tag=postgres-latest \
-Dquarkus.container-image.build=true
```

Expand Down
2 changes: 1 addition & 1 deletion getting-started/jdbc/docker-compose-bootstrap-db.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

services:
polaris-bootstrap:
image: apache/polaris-admin-tool:postgres-latest
image: apache/polaris-admin-tool:latest
environment:
- POLARIS_PERSISTENCE_TYPE=relational-jdbc
- QUARKUS_DATASOURCE_JDBC_URL=${QUARKUS_DATASOURCE_JDBC_URL}
Expand Down
2 changes: 1 addition & 1 deletion getting-started/jdbc/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
services:

polaris:
image: apache/polaris:postgres-latest
image: apache/polaris:latest
ports:
# API port
- "8181:8181"
Expand Down
2 changes: 1 addition & 1 deletion helm/polaris/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ ct install --namespace polaris --charts ./helm/polaris
| image.configDir | string | `"/deployments/config"` | The path to the directory where the application.properties file, and other configuration files, if any, should be mounted. Note: if you are using EclipseLink, then this value must be at least two folders down to the root folder, e.g. `/deployments/config` is OK, whereas `/deployments` is not. |
| image.pullPolicy | string | `"IfNotPresent"` | The image pull policy. |
| image.repository | string | `"apache/polaris"` | The image repository to pull from. |
| image.tag | string | `"1.1.0-incubating-SNAPSHOT"` | The image tag. |
| image.tag | string | `"latest"` | The image tag. |
| imagePullSecrets | list | `[]` | References to secrets in the same namespace to use for pulling any of the images used by this chart. Each entry is a LocalObjectReference to an existing secret in the namespace. The secret must contain a .dockerconfigjson key with a base64-encoded Docker configuration file. See https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ for more information. |
| ingress.annotations | object | `{}` | Annotations to add to the ingress. |
| ingress.className | string | `""` | Specifies the ingressClassName; leave empty if you don't want to customize it |
Expand Down
2 changes: 1 addition & 1 deletion helm/polaris/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ image:
# -- The image pull policy.
pullPolicy: IfNotPresent
# -- The image tag.
tag: "1.1.0-incubating-SNAPSHOT"
tag: "latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change, but let's wait for @flyrain to chime in.

# -- The path to the directory where the application.properties file, and other configuration
# files, if any, should be mounted.
# Note: if you are using EclipseLink, then this value must be at least two folders down to the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ cd ~/polaris
:polaris-server:quarkusAppPartsBuild --rerun \
:polaris-admin:assemble \
:polaris-admin:quarkusAppPartsBuild --rerun \
-Dquarkus.container-image.tag=postgres-latest \
-Dquarkus.container-image.build=true
```
- **For standalone**: Omit the `-Dquarkus.container-image.tag` and `-Dquarkus.container-image.build` options if you do not need to build a Docker image.
Expand Down
2 changes: 1 addition & 1 deletion site/content/in-dev/unreleased/helm.md
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ ct install --namespace polaris --charts ./helm/polaris
| image.configDir | string | `"/deployments/config"` | The path to the directory where the application.properties file, and other configuration files, if any, should be mounted. Note: if you are using EclipseLink, then this value must be at least two folders down to the root folder, e.g. `/deployments/config` is OK, whereas `/deployments` is not. |
| image.pullPolicy | string | `"IfNotPresent"` | The image pull policy. |
| image.repository | string | `"apache/polaris"` | The image repository to pull from. |
| image.tag | string | `"1.1.0-incubating-SNAPSHOT"` | The image tag. |
| image.tag | string | `"latest"` | The image tag. |
| imagePullSecrets | list | `[]` | References to secrets in the same namespace to use for pulling any of the images used by this chart. Each entry is a LocalObjectReference to an existing secret in the namespace. The secret must contain a .dockerconfigjson key with a base64-encoded Docker configuration file. See https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ for more information. |
| ingress.annotations | object | `{}` | Annotations to add to the ingress. |
| ingress.className | string | `""` | Specifies the ingressClassName; leave empty if you don't want to customize it |
Expand Down