Skip to content

Remove postgres_latest as image tag #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MonkeyCanCode
Copy link
Contributor

@MonkeyCanCode MonkeyCanCode commented Jul 14, 2025

Based from both #2036 and #1957, we will be removing postgres_latest as image tag and use latest as image tag instead.

adutra
adutra previously approved these changes Jul 15, 2025
Copy link
Contributor

@adutra adutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MonkeyCanCode!

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jul 15, 2025
@snazy
Copy link
Member

snazy commented Jul 15, 2025

Wait a sec ...

@snazy
Copy link
Member

snazy commented Jul 15, 2025

Nope, all good. I see you removed the -SNAPSHOT reference.

For posterity: as an Apache project we have to direct users to official releases, never to snapshots, nightlies and similar.
Since you're referring to the Docker repo for official releases, that's fine.

@MonkeyCanCode
Copy link
Contributor Author

Nope, all good. I see you removed the -SNAPSHOT reference.

For posterity: as an Apache project we have to direct users to official releases, never to snapshots, nightlies and similar.
Since you're referring to the Docker repo for official releases, that's fine.

Oh, that is good to know. In that case, we will need to change the value files in the helm right? That is referring to the snapshot one @adutra

@adutra
Copy link
Contributor

adutra commented Jul 15, 2025

Oh, that is good to know. In that case, we will need to change the value files in the helm right? That is referring to the snapshot one @adutra

I guess you are right... we should use tag: latest instead of tag: "1.1.0-incubating-SNAPSHOT".

I don't know why #1957 included a -SNAPSHOT tag in the chart... oddly enough, the tag exists, but it doesn't align with our recent discussions about nightly images in #1593. @flyrain do you remember the rationale? I think we need to revisit this, imho the safest choice is to go with latest.

@adutra
Copy link
Contributor

adutra commented Jul 16, 2025

OK I finally found the discussion I had with @flyrain about image tags:

#1944 (comment)

Yufei was advocating for specific tags in case users want to downgrade the helm chart.

I confess I'm now thinking that it's too much hassle keeping specific Docker image versions in the Helm chart compared to the (limited) benefits. Besides, if we move the Helm chart out of this repo, as it was proposed, then it probably doesn't make sense at all to use specific versions in image.tag.

@@ -27,7 +27,7 @@ image:
# -- The image pull policy.
pullPolicy: IfNotPresent
# -- The image tag.
tag: "1.1.0-incubating-SNAPSHOT"
tag: "latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change, but let's wait for @flyrain to chime in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants