-
Notifications
You must be signed in to change notification settings - Fork 275
Remove postgres_latest as image tag #2045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MonkeyCanCode!
Wait a sec ... |
Nope, all good. I see you removed the For posterity: as an Apache project we have to direct users to official releases, never to snapshots, nightlies and similar. |
Oh, that is good to know. In that case, we will need to change the value files in the helm right? That is referring to the snapshot one @adutra |
I guess you are right... we should use I don't know why #1957 included a |
OK I finally found the discussion I had with @flyrain about image tags: Yufei was advocating for specific tags in case users want to downgrade the helm chart. I confess I'm now thinking that it's too much hassle keeping specific Docker image versions in the Helm chart compared to the (limited) benefits. Besides, if we move the Helm chart out of this repo, as it was proposed, then it probably doesn't make sense at all to use specific versions in |
@@ -27,7 +27,7 @@ image: | |||
# -- The image pull policy. | |||
pullPolicy: IfNotPresent | |||
# -- The image tag. | |||
tag: "1.1.0-incubating-SNAPSHOT" | |||
tag: "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this change, but let's wait for @flyrain to chime in.
Based from both #2036 and #1957, we will be removing
postgres_latest
as image tag and use latest as image tag instead.