Align PR template (3.x) #1103
+13
−19
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,23 @@ | ||
| Following this checklist to help us incorporate your | ||
| contribution quickly and easily: | ||
|
|
||
| - [ ] Your pull request should address just one issue, without pulling in other changes. | ||
| - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. | ||
| - [ ] Each commit in the pull request should have a meaningful subject line and body. | ||
|
Contributor
There was a problem hiding this comment. Not helpful. We don't bother paying attention to individual commit messages. Just keep the PR description reasonable (and with LLMs they're getting better lately) |
||
| Note that commits might be squashed by a maintainer on merge. | ||
| - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. | ||
|
|
||
| This may not always be possible but is a best-practice. | ||
| - [ ] Run `mvn verify` to make sure basic checks pass. | ||
| A more thorough check will be performed on your pull request automatically. | ||
| - [ ] You have run the integration tests successfully (`mvn -Prun-its verify`). | ||
|
|
||
| If your pull request is about ~20 lines of code you don't need to sign an | ||
| [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure | ||
| please ask on the developers list. | ||
|
|
||
| To make clear that you license your contribution under | ||
|
Contributor
There was a problem hiding this comment. Acknowledge that you license this contribution under |
||
| the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) | ||
| you have to acknowledge this by using the following check-box. | ||
|
|
||
| - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) | ||
| - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). | ||
|
Contributor
There was a problem hiding this comment. I have filed an Apache Individual Contributor License Agreement. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following --> Follow