Align PR template (3.x) - #1103
Closed
Bukama wants to merge 1 commit into
Closed
Conversation
Member
|
I think that templates are taken only from default branch |
elharo
requested changes
Aug 5, 2026
elharo
left a comment
elharo
left a comment
Contributor
There was a problem hiding this comment.
If this is just a copy of the base template, the base template has problems that should be fixed first.
| @@ -1,29 +1,23 @@ | |||
| Following this checklist to help us incorporate your | |||
| Following this checklist to help us incorporate your | |||
| - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). | ||
| - [ ] Your pull request should address just one issue, without pulling in other changes. | ||
| - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. | ||
| - [ ] Each commit in the pull request should have a meaningful subject line and body. |
Contributor
There was a problem hiding this comment.
Not helpful. We don't bother paying attention to individual commit messages. Just keep the PR description reasonable (and with LLMs they're getting better lately)
| - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. | ||
| - [ ] Each commit in the pull request should have a meaningful subject line and body. | ||
| Note that commits might be squashed by a maintainer on merge. | ||
| - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. |
| please ask on the developers list. | ||
|
|
||
| To make clear that you license your contribution under | ||
| To make clear that you license your contribution under |
Contributor
There was a problem hiding this comment.
Acknowledge that you license this contribution under
the Apache License Version 2.0, January 2004
by ticking one of these two checkboxes:
| - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). | ||
|
|
||
| - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) | ||
| - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). |
Contributor
There was a problem hiding this comment.
I have filed an Apache Individual Contributor License Agreement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.