HIVE-29506: HiveRelDecorrelator fails to decorrelate plan with Values operator

ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java

@@ -30,7 +30,6 @@
 import java.util.Set;
 import java.util.SortedMap;
 import java.util.TreeMap;
-import java.util.TreeSet;
 
 import javax.annotation.Nonnull;
 
@@ -57,7 +56,6 @@
 import org.apache.calcite.rel.core.JoinRelType;
 import org.apache.calcite.rel.core.Project;
 import org.apache.calcite.rel.core.Sort;
-import org.apache.calcite.rel.core.Values;
 import org.apache.calcite.rel.logical.LogicalCorrelate;
 import org.apache.calcite.rel.metadata.RelMdUtil;
 import org.apache.calcite.rel.metadata.RelMetadataQuery;
@@ -112,7 +110,6 @@
 import org.slf4j.LoggerFactory;
 
 import com.google.common.base.Preconditions;
-import com.google.common.base.Supplier;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
@@ -461,16 +458,6 @@ public Frame decorrelateRel(Sort rel) {
             frame.corDefOutputs);
   }
 
-  /**
-   * Rewrites a {@link Values}.
-   *
-   * @param rel Values to be rewritten
-   */
-  public Frame decorrelateRel(Values rel) {
-    // There are no inputs, so rel does not need to be changed.
-    return null;
-  }
-
   /**
    * Rewrites a {@link Aggregate}.
    *

ql/src/test/queries/clientpositive/empty_result_correlate2.q

@@ -0,0 +1,22 @@
+set hive.support.concurrency=true;
+set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
+
+-- To create a HiveValues operator before decorrelation automatic query rewrite with
+-- materialized views is used.
+-- All tables must be transactional to trigger automatic query rewrite.
+create table mv_source (any_col int) stored as orc TBLPROPERTIES ('transactional'='true');
+create table t1 (a int, b int) stored as orc TBLPROPERTIES ('transactional'='true');
+create table t2 (a int, b int) stored as orc TBLPROPERTIES ('transactional'='true');
+
+-- At least one materialized view must exist.
+create materialized view any_mv as
+select any_col from mv_source where any_col > 20;
+
+-- Automatic query rewrite traverses the plan and recreates the HiveFilter using RelBuilder.
+-- If the condition is always false, it replaces the filter with HiveValues.
+explain cbo
+select * from t1 where 1 = 2
+union
+select * from t1
+where exists (select a from t2 where t1.a > 10)
+;

ql/src/test/results/clientpositive/llap/empty_result_correlate2.q.out

@@ -0,0 +1,73 @@
+PREHOOK: query: create table mv_source (any_col int) stored as orc TBLPROPERTIES ('transactional'='true')
+PREHOOK: type: CREATETABLE
+PREHOOK: Output: database:default
+PREHOOK: Output: default@mv_source
+POSTHOOK: query: create table mv_source (any_col int) stored as orc TBLPROPERTIES ('transactional'='true')
+POSTHOOK: type: CREATETABLE
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@mv_source
+PREHOOK: query: create table t1 (a int, b int) stored as orc TBLPROPERTIES ('transactional'='true')
+PREHOOK: type: CREATETABLE
+PREHOOK: Output: database:default
+PREHOOK: Output: default@t1
+POSTHOOK: query: create table t1 (a int, b int) stored as orc TBLPROPERTIES ('transactional'='true')
+POSTHOOK: type: CREATETABLE
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@t1
+PREHOOK: query: create table t2 (a int, b int) stored as orc TBLPROPERTIES ('transactional'='true')
+PREHOOK: type: CREATETABLE
+PREHOOK: Output: database:default
+PREHOOK: Output: default@t2
+POSTHOOK: query: create table t2 (a int, b int) stored as orc TBLPROPERTIES ('transactional'='true')
+POSTHOOK: type: CREATETABLE
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@t2
+PREHOOK: query: create materialized view any_mv as
+select any_col from mv_source where any_col > 20
+PREHOOK: type: CREATE_MATERIALIZED_VIEW
+PREHOOK: Input: default@mv_source
+PREHOOK: Output: database:default
+PREHOOK: Output: default@any_mv
+POSTHOOK: query: create materialized view any_mv as
+select any_col from mv_source where any_col > 20
+POSTHOOK: type: CREATE_MATERIALIZED_VIEW
+POSTHOOK: Input: default@mv_source
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@any_mv
+POSTHOOK: Lineage: any_mv.any_col SIMPLE [(mv_source)mv_source.FieldSchema(name:any_col, type:int, comment:null), ]
+Warning: Shuffle Join MERGEJOIN[38][tables = [$hdt$_1, $hdt$_2]] in Stage 'Reducer 5' is a cross product
+PREHOOK: query: explain cbo
+select * from t1 where 1 = 2
+union
+select * from t1
+where exists (select a from t2 where t1.a > 10)
+PREHOOK: type: QUERY
+PREHOOK: Input: default@t1
+PREHOOK: Input: default@t2
+#### A masked pattern was here ####
+POSTHOOK: query: explain cbo
+select * from t1 where 1 = 2
+union
+select * from t1
+where exists (select a from t2 where t1.a > 10)
+POSTHOOK: type: QUERY
+POSTHOOK: Input: default@t1
+POSTHOOK: Input: default@t2
+#### A masked pattern was here ####
+CBO PLAN:
+HiveProject(a=[$0], b=[$1])
+  HiveAggregate(group=[{0, 1}])
+    HiveSemiJoin(condition=[=($3, $2)], joinType=[semi])
+      HiveProject(a=[$0], b=[$1], $f6=[>($0, 10)])
+        HiveFilter(condition=[IS NOT NULL($0)])
+          HiveTableScan(table=[[default, t1]], table:alias=[t1])
+      HiveProject($f6=[$1])
+        HiveJoin(condition=[true], joinType=[inner], algorithm=[none], cost=[not available])
+          HiveProject(DUMMY=[0])
+            HiveTableScan(table=[[default, t2]], table:alias=[t2])
+          HiveProject($f6=[$0])
+            HiveAggregate(group=[{0}])
+              HiveProject($f6=[CAST(IS NOT NULL($0)):BOOLEAN])
+                HiveFilter(condition=[>($0, 10)])
+                  HiveTableScan(table=[[default, t1]], table:alias=[t1])
+