HIVE-29506: HiveRelDecorrelator fails to decorrelate plan with Values operator#6360
Open
kasakrisz wants to merge 2 commits intoapache:masterfrom
Open
HIVE-29506: HiveRelDecorrelator fails to decorrelate plan with Values operator#6360kasakrisz wants to merge 2 commits intoapache:masterfrom
kasakrisz wants to merge 2 commits intoapache:masterfrom
Conversation
kasakrisz
force-pushed
the
HIVE-29506-master-decorrelate-values
branch
from
c1e7433 to
3331420
Compare
|
deniskuzZ
reviewed
Mar 18, 2026
| -- To create a HiveValues operator before decorrelation automatic query rewrite with | ||
| -- materialized views is used. | ||
| -- All tables must be transactional to trigger automatic query rewrite. | ||
| create table mv_source (any_col int) stored as orc TBLPROPERTIES ('transactional'='true'); |
Member
There was a problem hiding this comment.
not sure we should be adding new tests with ACID table format, would it work with iceberg as well?
Contributor
There was a problem hiding this comment.
The bug should occur when decorrelating any plan with a Values node. How about adding a unit test in a new class HiveRelDecorrelatorTest instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the special handling of the
Valuesoperator fromHiveRelDecorrelatorWhy are the changes needed?
The specialization returned
null, signaling the decorrelator algorithm to stop and return the original plan. Consequently,Correlateoperators may remain in the plan, which Hive cannot handle.Does this PR introduce any user-facing change?
No.
How was this patch tested?