[FLINK-35176][Connector/JDBC] Support property authentication connection for JDBC catalog & dynamic table #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RocMarshal
commented
Apr 19, 2024
RocMarshal
commented
- Support property authentication connection for JDBC catalog & dynamic table
RocMarshal
changed the title
|
blocked by #115 |
|
HI, @caicancai @GOODBOY008 Could you help have a review if you had the free time ? thx a lot. |
caicancai
reviewed
Apr 26, 2024
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java
Show resolved
Hide resolved
RocMarshal
commented
Apr 26, 2024
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java
Show resolved
Hide resolved
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/JdbcCatalog.java
Show resolved
Hide resolved
|
Thanks @caicancai for the review. |
|
Hi, @eskabetxe Would you mind having take a look if you had the free time ? Many thx! |
eskabetxe
reviewed
Apr 30, 2024
| this.baseUrl = baseUrl.endsWith("/") ? baseUrl : baseUrl + "/"; | ||
| this.defaultUrl = this.baseUrl + defaultDatabase; | ||
| this.connectionProperties = Preconditions.checkNotNull(connectionProperties); | ||
| if (StringUtils.isNullOrWhitespaceOnly(connectionProperties.getProperty(USER_KEY))) { |
There was a problem hiding this comment.
we should maintain the current checks
checkArgument(!StringUtils.isNullOrWhitespaceOnly(connectionProperties.getProperty(USER_KEY)));
checkArgument(!StringUtils.isNullOrWhitespaceOnly(connectionProperties.getProperty(PASSWORD_KEY)));
|
Thanks @eskabetxe for the comments. Updated. |
1996fanrui
reviewed
May 7, 2024
There was a problem hiding this comment.
Thanks @RocMarshal for the contribution, and @eskabetxe @caicancai for the review!
Merging~
…ion for JDBC catalog
…ion for dynamic jdbc source table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.