-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source #117
Conversation
RocMarshal
commented
Apr 20, 2024
- Support the implementation of dynamic source tables based on the new source
a9ba994
to
645758b
Compare
blocked by #116 |
HI, @eskabetxe @caicancai Could you help have a review if you had the free time ? thx a lot. |
01a36e8
to
cda6098
Compare
…on check timeout seconds
e4f5344
to
db7d938
Compare
...nnector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java
Outdated
Show resolved
Hide resolved
...or-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eskabetxe for the review.
I made some change based on your comments.
PTAL if you had the free time~ :)
…ource tables based on the new source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eskabetxe for the quick review~
now ping @1996fanrui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RocMarshal for the contribution, and @eskabetxe for the hard review!
LGTM
Hi, @1996fanrui . So, Maybe we should revert this commit and re-commit it in the next second or third version |
Sounds make sense to me. The JdbcSource is introduced in the current version, it may be not stable. So it's better to consider it as the default Jdbc connector for SQL job after community think it's stable. |