Skip to content

Set catalog_list from outside for SessionState. #5277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Set catalog_list from outside for SessionState. #5277

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf524a
Set `catalog_list` from outside for `SessionState`.
MichaelScofield Feb 14, 2023
d397ae2
fix: resolve PR comments
MichaelScofield Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion datafusion/core/src/execution/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1475,9 +1475,18 @@ pub fn default_session_builder(config: SessionConfig) -> SessionState {
impl SessionState {
/// Returns new SessionState using the provided configuration and runtime
pub fn with_config_rt(config: SessionConfig, runtime: Arc<RuntimeEnv>) -> Self {
let catalog_list = Arc::new(MemoryCatalogList::new()) as Arc<dyn CatalogList>;
Self::with_config_rt_and_catalog_list(config, runtime, catalog_list)
}

/// Returns new SessionState using the provided configuration, runtime and catalog list.
pub fn with_config_rt_and_catalog_list(
config: SessionConfig,
runtime: Arc<RuntimeEnv>,
catalog_list: Arc<dyn CatalogList>,
) -> Self {
let session_id = Uuid::new_v4().to_string();

let catalog_list = Arc::new(MemoryCatalogList::new()) as Arc<dyn CatalogList>;
if config.create_default_catalog_and_schema() {
let default_catalog = MemoryCatalogProvider::new();

Expand Down