Skip to content

7.x: fix clippy #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 7, 2022
Merged

7.x: fix clippy #2166

merged 6 commits into from
Apr 7, 2022

Conversation

jychen7
Copy link
Contributor

@jychen7 jychen7 commented Apr 6, 2022

Which issue does this PR close?

fix clippy

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Apr 6, 2022
@jychen7 jychen7 mentioned this pull request Apr 6, 2022
Merged
@jackwener
Copy link
Member

It was forgotten.

   --> datafusion/tests/merge_fuzz.rs:106:20
    |
106 |               .iter()
    |  ____________________^
107 | |             .map(|p| p.iter())
108 | |             .flatten()
    | |______________________^ help: try using `flat_map` instead: `.flat_map(|p| p.iter())`

alamb
alamb approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thank you @jychen7.

@jychen7
Copy link
Contributor Author

jychen7 commented Apr 7, 2022 •
edited
Loading

It was forgotten

hi, my macOS have problem running with cargo clippy (similar to rust-lang/rust-clippy#8470) and run in docker shows no error, so I just relies on CI for the checking (And CI didn't show all errors at once)

I will mark this PR as "Ready for review" once clippy pass

@jychen7 jychen7 marked this pull request as ready for review April 7, 2022 02:45
@yjshen yjshen merged commit 5aa689f into apache:maint-7.x Apr 7, 2022
@yjshen
Copy link
Member

yjshen commented Apr 7, 2022

Thanks @jychen7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@jackwener jackwener jackwener approved these changes

Assignees
No one assigned
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jychen7 @jackwener @yjshen @alamb