#2109 schema infer max #2159
Merged
#2109 schema infer max #2159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
same as https://github.com/apache/arrow-datafusion/pull/1885/files which already in master
jychen7
commented
Apr 5, 2022
| @@ -26,7 +26,7 @@ pub use env_logger; | |||
| pub fn batches_to_vec(batches: &[RecordBatch]) -> Vec<Option<i32>> { | |||
| batches | |||
| .iter() | |||
| .map(|batch| { | |||
| .flat_map(|batch| { | |||
There was a problem hiding this comment.
yjshen
approved these changes
Apr 5, 2022
alamb
approved these changes
Apr 5, 2022
|
Looks like there are some other clippy errors left on the maint branch -- if you want we can merge this PR in as is and then we can fix the clippy errors on the maint branch as a follow on PR |
|
the clippy error impact quite a few files, would be better we resolve in new PR |
I agree -- merged this one in |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
patch v7.x with #2109
was merged to
masterat #2139Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?