fix: Make conversion from FileDecryptionProperties to ConfigFileDecryptionProperties fallible#21603
Open
adamreeve wants to merge 5 commits intoapache:mainfrom
Open
fix: Make conversion from FileDecryptionProperties to ConfigFileDecryptionProperties fallible#21603adamreeve wants to merge 5 commits intoapache:mainfrom
adamreeve wants to merge 5 commits intoapache:mainfrom
Conversation
github-actions
bot
added
core
adamreeve
force-pushed
the
fallible-decrypt-config-convert
branch
from
8cc9c06 to
6d380a1
Compare
github-actions
bot
added
the
documentation
adamreeve
force-pushed
the
fallible-decrypt-config-convert
branch
from
d3f2020 to
dc8ad1a
Compare
adamreeve
force-pushed
the
fallible-decrypt-config-convert
branch
from
dc8ad1a to
704d0f1
Compare
kumarUjjawal
approved these changes
Apr 16, 2026
Contributor
kumarUjjawal
left a comment
kumarUjjawal
left a comment
There was a problem hiding this comment.
LGTM, let's wait for someone else to have another look.
Contributor
Author
|
Thanks for the review @kumarUjjawal! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Fail quickly with a helpful error if we're unable to represent a
FileDecryptionPropertiesinstance asConfigFileDecryptionPropertiesWhat changes are included in this PR?
From<&Arc<FileDecryptionProperties>>forConfigFileDecryptionPropertiestoTryFrom.FileDecryptionPropertieswith empty metadataAre these changes tested?
Yes I've added a new unit test.
I also tested this with a branch of delta-rs that uses Datafusion with Parquet encryption, and this required only minor changes to tests and examples: corwinjoy/delta-rs@file_format_options_squashed...adamreeve:delta-rs:test-datafusion-change
Are there any user-facing changes?
Yes, this is a breaking API change.