Skip to content

Commit 704d0f1

Browse files
committed
Add section to upgrade guide
1 parent 6d380a1 commit 704d0f1

File tree

1 file changed

+19
-0
lines changed
  • docs/source/library-user-guide/upgrading

1 file changed

+19
-0
lines changed

docs/source/library-user-guide/upgrading/54.0.0.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -438,3 +438,22 @@ clusters (e.g., ZWJ emoji sequences). For ASCII and most common Unicode text,
438438
behavior is unchanged.
439439

440440
[#17861]: https://github.com/apache/datafusion/pull/17861
441+
442+
### Conversion from `FileDecryptionProperties` to `ConfigFileDecryptionProperties` is now fallible
443+
444+
Previously, `datafusion_common::config::ConfigFileDecryptionProperties`
445+
implemented `From<&Arc<parquet::encryption::decrypt::FileDecryptionProperties>>`.
446+
If an error was encountered when retrieving the footer key without providing key metadata,
447+
the error would be ignored and an empty footer key set in the result.
448+
This could lead to obscure errors later.
449+
450+
`ConfigFileDecryptionProperties` now instead implements `TryFrom<&Arc<FileDecryptionProperties>>`,
451+
and errors retrieving the footer key will be propagated up.
452+
453+
Code that uses `ConfigFileDecryptionProperties::from(&Arc<FileDecryptionProperties>)`
454+
should be updated to use `try_from`,
455+
and calls to `FileDecryptionProperties::into` should be changed to `try_into`,
456+
with appropriate error handling added.
457+
458+
See [#21602](https://github.com/apache/datafusion/issues/21602) and
459+
[PR #21603](https://github.com/apache/datafusion/pull/21603) for details.

0 commit comments

Comments
 (0)