Refactor binary.rs tests into modular submodules under binary/tests
#16782
+1,173
−1,095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
binary.rs
Tests into Dedicated Modules #16767Rationale for this change
This refactor improves the organization and maintainability of the type coercion tests in the
datafusion/expr-common
crate.By grouping related tests into separate modules (
arithmetic.rs
,comparison.rs
,dictionary.rs
,null_coercion.rs
), it makes the test suite easier to navigate, extend, and review.What changes are included in this PR?
binary.rs
into dedicated submodules underbinary/tests/
arithmetic.rs
— arithmetic coercion and numeric testscomparison.rs
— comparison, like, binary ops, map and list coercion testsdictionary.rs
— dictionary coercion testsnull_coercion.rs
— logical ops and null coercion teststests/mod.rs
Are these changes tested?
✅ Yes — This PR only reorganizes existing, already tested code.
All tests continue to run under the new module structure.
Are there any user-facing changes?
❌ No — This is an internal refactor of test code only.
There are no changes to user-facing APIs or behavior.