Skip to content

Conversation

@zhuqi-lucas
Copy link
Contributor

@zhuqi-lucas zhuqi-lucas commented Jul 11, 2025

Which issue does this PR close?

Optimize following cases, and add more fast path.

do_append_val_inner
do_equal_to_inner

This is wasteful if there is no data buffer, in which case we can improve the performance.

Also, i do some fast path which is done in arrow-rs.

Rationale for this change

Optimize following cases, and add more fast path.

do_append_val_inner
do_equal_to_inner

What changes are included in this PR?

Optimize following cases, and add more fast path.

do_append_val_inner
do_equal_to_inner

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-plan Changes to the physical-plan crate label Jul 11, 2025
@Rachelint
Copy link
Contributor

Thanks @zhuqi-lucas ! How about the benchmark result?

@zhuqi-lucas
Copy link
Contributor Author

zhuqi-lucas commented Jul 12, 2025

Thank you @Rachelint , it seems no performance improvement for clickbench from my local Mac benchmark, i need to investigate further.

@Rachelint
Copy link
Contributor

Rachelint commented Jul 12, 2025

Thank you @Rachelint , it seems no performance improvement for clickbench from my local Mac benchmark, i need to investigate further.

Yes... I made a simple try only in append path before, and also found no obvious improvement... We indeed need further investigation maybe

@zhuqi-lucas zhuqi-lucas marked this pull request as draft July 12, 2025 05:18
@zhuqi-lucas
Copy link
Contributor Author

zhuqi-lucas commented Jul 12, 2025

Thank you @Rachelint , it seems no performance improvement for clickbench from my local Mac benchmark, i need to investigate further.

Yes... I made a simple try only in append path before, and also found no obvious improvement... We indeed need further investigation maybe

I agree, converted it a draft now.

@github-actions
Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Sep 11, 2025
@github-actions github-actions bot closed this Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate Stale PR has not had any activity for some time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize performance of ByteViewGroupValueBuilder on batches with inlined views

2 participants