Skip to content

Add benchmark for ByteViewGroupValueBuilder #16826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zhuqi-lucas
Copy link
Contributor

Which issue does this PR close?

Add some benchmark before we try to optimize following topic:
#16330

#16751

Rationale for this change

Add some benchmark before we try to optimize following topic:
#16330

#16751

What changes are included in this PR?

Add the benchmark for ByteViewGroupValueBuilder.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-plan Changes to the physical-plan crate label Jul 19, 2025
Copy link
Contributor

@2010YOUY01 2010YOUY01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

BTW, for end-to-end aggregate queries -- is the hot spot only this vectorized_append() in this benchmark? Should we add other functions that also take significant time in query executions?

@zhuqi-lucas
Copy link
Contributor Author

zhuqi-lucas commented Jul 21, 2025

LGTM, thanks.

BTW, for end-to-end aggregate queries -- is the hot spot only this vectorized_append() in this benchmark? Should we add other functions that also take significant time in query executions?

Thank you @2010YOUY01 for review, i agree that we can add more hot functions, i am planning to add more hot function.

Updated: added all hot function vectorized_equal_to, append_val and vectorized_append.

@alamb alamb merged commit 70e7eb3 into apache:main Jul 21, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-plan Changes to the physical-plan crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants