Support custom field metadata in UDF #13458
Conversation
| @@ -216,6 +217,15 @@ impl ScalarUDF { | |||
| self.inner.is_nullable(args, schema) | |||
| } | |||
|
|
|||
| /// Returns the field metadata for this function. | |||
| pub fn metadata( | |||
There was a problem hiding this comment.
Looks like not. This pr is for supporting custom metadata when converting scalar function expr to schema field during planing.
| @@ -477,6 +487,15 @@ pub trait ScalarUDFImpl: Debug + Send + Sync { | |||
| true | |||
| } | |||
|
|
|||
| /// Returns the field metadata for this function. | |||
There was a problem hiding this comment.
I think a more detailed explanation would be useful for someone adding a new UDF to know why this method exists and what use case it is trying to solve. Without looking at this PR it's pretty opaque.
|
I think a test would be in order that would showcase why the new metadata method exists and what problem it solves. |
I agree. |
|
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Which issue does this PR close?
Closes #.
Rationale for this change
In our case, we need put type data in schema metadata for supporting logical type. But there is no good way for the column generated by UDF.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?