chore: Drop support for Java 8 #1777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
andygrove
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1777 +/- ##
============================================
+ Coverage 56.12% 58.55% +2.42%
- Complexity 976 1138 +162
============================================
Files 119 130 +11
Lines 11743 12684 +941
Branches 2251 2363 +112
============================================
+ Hits 6591 7427 +836
- Misses 4012 4073 +61
- Partials 1140 1184 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
requested review from
kazuyukitanimura,
Copilot and
comphead
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR drops support for Java 8 to allow upgrading arrow‑java to 18.3.0, which no longer supports Java 8. The key changes include:
- Removal of the Java 8 (jdk1.8) Maven profile from pom.xml.
- Updating documentation to reflect support only for JDK 11/17.
- Adjusting CI workflows in .github/workflows/pr_build.yml to remove Java 8 from the test matrices.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pom.xml | Removed the jdk1.8 profile to eliminate Java 8-specific configurations. |
| docs/source/user-guide/installation.md | Updated the supported Java version table to remove Java 8. |
| docs/source/contributor-guide/development.md | Modified JDK reference from 8/11/17 to 11/17 in setup instructions. |
| .github/workflows/pr_build.yml | Updated CI test matrices to exclude Java 8 and, in one case, test only Java 17. |
Comments suppressed due to low confidence (1)
.github/workflows/pr_build.yml:321
- In the 'macos-aarch64-test-with-old-spark' workflow, only Java 17 is being tested compared to other workflows that test both Java 11 and 17. Please confirm if omitting Java 11 here is intentional to ensure adequate test coverage.
java_version: [17]
comphead
reviewed
May 23, 2025
Co-authored-by: Oleks V <[email protected]>
kazuyukitanimura
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1775
Rationale for this change
We want to upgrade to arrow-java 18.3.0 to pick up an important bug fix, but arrow-java no longer supports Java 8.
What changes are included in this PR?
How are these changes tested?