Skip to content

Commit e25be9e

Browse files
andygrovecomphead
andauthored
chore: Drop support for Java 8 (#1777)
* drop support for Java 8 * Update development.md Co-authored-by: Oleks V <[email protected]> --------- Co-authored-by: Oleks V <[email protected]>
1 parent 15bbadb commit e25be9e

File tree

4 files changed

+12
-25
lines changed

4 files changed

+12
-25
lines changed

.github/workflows/pr_build.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
strategy:
4747
matrix:
4848
os: [ubuntu-latest]
49-
java_version: [8, 11, 17]
49+
java_version: [11, 17]
5050
test-target: [rust, java]
5151
spark-version: ['3.5']
5252
scala-version: ['2.12', '2.13']
@@ -180,7 +180,7 @@ jobs:
180180
strategy:
181181
matrix:
182182
os: [ubuntu-latest]
183-
java_version: [8, 11, 17]
183+
java_version: [11, 17]
184184
test-target: [java]
185185
spark-version: ['3.4']
186186
scala-version: ['2.12', '2.13']
@@ -205,7 +205,7 @@ jobs:
205205
strategy:
206206
matrix:
207207
os: [macos-13]
208-
java_version: [8, 11, 17]
208+
java_version: [11, 17]
209209
test-target: [rust, java]
210210
spark-version: ['3.4', '3.5']
211211
scala-version: ['2.12', '2.13']
@@ -232,7 +232,7 @@ jobs:
232232
macos-aarch64-test:
233233
strategy:
234234
matrix:
235-
java_version: [8, 11, 17]
235+
java_version: [11, 17]
236236
test-target: [rust, java]
237237
spark-version: ['3.4', '3.5']
238238
scala-version: ['2.12', '2.13']
@@ -318,7 +318,7 @@ jobs:
318318
macos-aarch64-test-with-old-spark:
319319
strategy:
320320
matrix:
321-
java_version: [8, 17]
321+
java_version: [17]
322322
test-target: [java]
323323
spark-version: ['3.4']
324324
scala-version: ['2.12', '2.13']

docs/source/contributor-guide/development.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ under the License.
3030

3131
## Development Setup
3232

33-
1. Make sure `JAVA_HOME` is set and point to JDK 8/11/17 installation.
33+
1. Make sure `JAVA_HOME` is set and point to JDK using (support matrix)[docs/source/user-guide/installation.md]
3434
2. Install Rust toolchain. The easiest way is to use
3535
[rustup](https://rustup.rs).
3636

docs/source/user-guide/installation.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ We recommend only using Comet with Spark versions where we currently have both C
3838
Other versions may work well enough for development and evaluation purposes.
3939

4040
| Spark Version | Java Version | Scala Version | Comet Tests in CI | Spark Tests in CI |
41-
| ------------- | ------------ | ------------- |-------------------| ----------------- |
42-
| 3.4.3 | 8/11/17 | 2.12/2.13 | Yes | Yes |
43-
| 3.5.2 | 8/11/17 | 2.12/2.13 | Partial\* | No |
44-
| 3.5.3 | 8/11/17 | 2.12/2.13 | Partial\* | No |
45-
| 3.5.4 | 8/11/17 | 2.12/2.13 | Partial\* | Yes |
46-
| 3.5.5 | 8/11/17 | 2.12/2.13 | Yes | Yes |
41+
| ------------- | ------------ | ------------- | ----------------- | ----------------- |
42+
| 3.4.3 | 11/17 | 2.12/2.13 | Yes | Yes |
43+
| 3.5.2 | 11/17 | 2.12/2.13 | Partial\* | No |
44+
| 3.5.3 | 11/17 | 2.12/2.13 | Partial\* | No |
45+
| 3.5.4 | 11/17 | 2.12/2.13 | Partial\* | Yes |
46+
| 3.5.5 | 11/17 | 2.12/2.13 | Yes | Yes |
4747

4848
\* For older Spark 3.5.x releases, we do not test the full matrix of supported Java and Scala versions in CI.
4949

pom.xml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -627,19 +627,6 @@ under the License.
627627
</properties>
628628
</profile>
629629

630-
<profile>
631-
<id>jdk1.8</id>
632-
<activation>
633-
<jdk>1.8</jdk>
634-
</activation>
635-
<properties>
636-
<java.version>1.8</java.version>
637-
<maven.compiler.source>${java.version}</maven.compiler.source>
638-
<maven.compiler.target>${java.version}</maven.compiler.target>
639-
<spotless.version>2.29.0</spotless.version>
640-
</properties>
641-
</profile>
642-
643630
<profile>
644631
<id>jdk11</id>
645632
<activation>

0 commit comments

Comments
 (0)