Skip to content

ASF: remove gradle-wrapper.jar file to make ASF compliant#81

Open
ostinru wants to merge 10 commits intoapache:mainfrom
ostinru:fix-asf-release
Open

ASF: remove gradle-wrapper.jar file to make ASF compliant#81
ostinru wants to merge 10 commits intoapache:mainfrom
ostinru:fix-asf-release

Conversation

@ostinru
Copy link
Collaborator

@ostinru ostinru commented Mar 16, 2026

Update Gradle scripts to match ASF compliance:

  • Remove gradle wrapper from ASF Releases and leave it in git repository (mimic apache/calcite project).
  • Fetch gradle wrapper during build phase (mimic apache/nessie)

Add checksum validation:

@tuhaihe
Copy link
Member

tuhaihe commented Mar 17, 2026

Cool! Thanks @ostinru for your great work!

I know this PR is still in the draft, just a reminder in case we're missing, FYI:

  • Maybe we can add the .github/workflows/gradle-wrapper-validation.yml
  • Remove the file server/gradle/wrapper/gradle-wrapper.jar from the source code
  • Can add a note in the README.md, like:

PXF does not vendor gradle-wrapper.jar in the source tree. When running make, you will download it from its official site.

@ostinru
Copy link
Collaborator Author

ostinru commented Mar 17, 2026

We can choose only one option from this two:

  • Maybe we can add the .github/workflows/gradle-wrapper-validation.yml
  • Remove the file server/gradle/wrapper/gradle-wrapper.jar from the source code

@tuhaihe
Copy link
Member

tuhaihe commented Mar 17, 2026

We can choose only one option from this two:

  • Maybe we can add the .github/workflows/gradle-wrapper-validation.yml
  • Remove the file server/gradle/wrapper/gradle-wrapper.jar from the source code

Got it. As suggested by the Incubator PMC, we should choose the 2nd one, removing the .jar file completely. Thanks!

@ostinru ostinru marked this pull request as ready for review March 17, 2026 08:59
@ostinru
Copy link
Collaborator Author

ostinru commented Mar 17, 2026

Got it. As suggested by the Incubator PMC, we should choose the 2nd one, removing the .jar file completely. Thanks!

Done.

@ostinru ostinru requested a review from tuhaihe March 17, 2026 11:35
@tuhaihe
Copy link
Member

tuhaihe commented Mar 17, 2026

Got it. As suggested by the Incubator PMC, we should choose the 2nd one, removing the .jar file completely. Thanks!

Done.

Cool! Will check this PR again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants