ASF: update files to make ASF compliance#80
Conversation
| sudo apt install -y openjdk-11-jdk maven | ||
| sudo apt install -y openjdk-11-jdk maven curl unzip coreutils | ||
|
|
||
| # Install Gradle (we do not vendor gradle-wrapper.jar in the source tree) |
There was a problem hiding this comment.
It seems that gradle-wrapper.jar is recommended way to work with gradle. Is there ASF compliance issue with this JAR?
https://docs.gradle.org/current/userguide/gradle_wrapper.html
There was a problem hiding this comment.
Yes, gradle-wrapper.jar is not allowed to be shipped in the release. See: https://lists.apache.org/thread/hrj8wfcyjllygq93qjzgbzmcyfg9h4f4. I'm trying to see how to download it instead of bundling it in the source code.
There was a problem hiding this comment.
It's really unusual to use system-wide gradle.
As I can see:
- apache/kafka keeps
gradlewin source tree. - apache/calcite keeps
gradlewin source tree and remove from source bundles: https://issues.apache.org/jira/browse/CALCITE-4575
There was a problem hiding this comment.
And I would suggest copying gradle-wrapper-validation.yml
https://github.com/apache/calcite/blob/main/.github/workflows/gradle-wrapper-validation.yml
There was a problem hiding this comment.
Hi @ostinru would you like to help create a PR to proceed with removing the *.jar from source files? I believe you are good at this from technical engineering more than me. The scope is beyond my ability now. Need your support here.
There was a problem hiding this comment.
We actually can take other projects as the reference.
closes: #ISSUE_Number
Change logs
Contributor's checklist
Here are some reminders before you submit your pull request: