Skip to content

ASF: update files to make ASF compliance#80

Draft
tuhaihe wants to merge 4 commits intoapache:mainfrom
tuhaihe:fix-asf-release-review
Draft

ASF: update files to make ASF compliance#80
tuhaihe wants to merge 4 commits intoapache:mainfrom
tuhaihe:fix-asf-release-review

Conversation

@tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Mar 16, 2026

closes: #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

Contributor's checklist

Here are some reminders before you submit your pull request:

@tuhaihe tuhaihe marked this pull request as draft March 16, 2026 06:38
sudo apt install -y openjdk-11-jdk maven
sudo apt install -y openjdk-11-jdk maven curl unzip coreutils

# Install Gradle (we do not vendor gradle-wrapper.jar in the source tree)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that gradle-wrapper.jar is recommended way to work with gradle. Is there ASF compliance issue with this JAR?

https://docs.gradle.org/current/userguide/gradle_wrapper.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, gradle-wrapper.jar is not allowed to be shipped in the release. See: https://lists.apache.org/thread/hrj8wfcyjllygq93qjzgbzmcyfg9h4f4. I'm trying to see how to download it instead of bundling it in the source code.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really unusual to use system-wide gradle.

As I can see:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ostinru would you like to help create a PR to proceed with removing the *.jar from source files? I believe you are good at this from technical engineering more than me. The scope is beyond my ability now. Need your support here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually can take other projects as the reference.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing here: ostinru#30

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks @ostinru !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants