Skip to content

[Java] Fix TextIO gzip split test on Windows #40078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xujiantop-crypto wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −5
Open

[Java] Fix TextIO gzip split test on Windows #40078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/io/TextIOReadTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assume.assumeFalse;

import java.io.BufferedWriter;
import java.io.File;
Expand Down Expand Up @@ -98,7 +97,6 @@
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Iterables;
import org.apache.commons.compress.compressors.bzip2.BZip2CompressorOutputStream;
import org.apache.commons.compress.compressors.deflate.DeflateCompressorOutputStream;
import org.apache.commons.lang3.SystemUtils;
import org.joda.time.Duration;
import org.junit.Rule;
import org.junit.Test;
Expand Down Expand Up @@ -1054,11 +1052,10 @@ public void testInitialSplitAutoModeTxt() throws Exception {

@Test
public void testInitialSplitAutoModeGz() throws Exception {
// TODO: Java core test failing on windows, https://github.com/apache/beam/issues/20470
assumeFalse(SystemUtils.IS_OS_WINDOWS);
PipelineOptions options = TestPipeline.testingPipelineOptions();
long desiredBundleSize = 1000;
File largeGz = writeToFile(LARGE, tempFolder, "large.gz", GZIP);
// Gzip output size varies across platforms, so derive a bundle size from the actual file.
long desiredBundleSize = largeGz.length() / 3;
// Sanity check: file is at least 2 bundles long.
assertThat(largeGz.length(), greaterThan(2 * desiredBundleSize));

Expand Down
Loading