[Java] Fix TextIO gzip split test on Windows - #40078
Open
xujiantop-crypto wants to merge 1 commit into
Open
Conversation
Signed-off-by: xujiantop-crypto <265865031+xujiantop-crypto@users.noreply.github.com>
Contributor
|
Assigning reviewers: R: @chamikaramj for label java. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20470
testInitialSplitAutoModeGzassumed the generated gzip file would always exceed 2,000 bytes. On Windows, the generated file is 1,970 bytes, so the test failed before exercisingFileBasedSource.split.This derives the requested bundle size from the actual compressed file length. The existing sanity check still proves the input spans more than two requested bundles, while removing the platform-dependent compression-size assumption and allowing the test to run on Windows.
Testing:
TextIOReadTest$BasicIOTest.testInitialSplitAutoModeGzon WindowsTextIOReadTest$BasicIOTeston Windows (12 tests):sdks:java:core:spotlessJavaCheck