fix(users): smart login redirect fallback when Dashboard not installed (#173) - #183
Merged
Merged
Conversation
When Dashboard is not installed, the login_redirect_url fallback was hard-coded to "/" which 404s on apps without a root route (e.g. smpy_gis). Now picks the first sibling module with a view_prefix instead, only falling back to "/" as an absolute last resort.
antosubash
added a commit
that referenced
this pull request
Jun 3, 2026
…190) PR #183 changed the post-login redirect to fall back to the first sibling module's view route (instead of hard-coding "/", which 404s on apps without a root route) when the Dashboard module isn't installed. The docs still described the old "/" fallback. Update the users settings table and the dashboard "Replacing it" section, and record the change in the CHANGELOG Unreleased/Fixed section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/(which 404s) when Dashboard module isn't installed, the code now finds the first module with aview_prefixand redirects there/only as an absolute last resort when no module has view routesFixes #173
Test plan
/dashboard/