docs(users,dashboard): describe smart login-redirect fallback (#173) - #190
Merged
Conversation
PR #183 changed the post-login redirect to fall back to the first sibling module's view route (instead of hard-coding "/", which 404s on apps without a root route) when the Dashboard module isn't installed. The docs still described the old "/" fallback. Update the users settings table and the dashboard "Replacing it" section, and record the change in the CHANGELOG Unreleased/Fixed section.
Deploying simple-module-python with
|
| Latest commit: |
9a9d0ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1ab7c2c1.simple-module-python.pages.dev |
| Branch Preview URL: | https://worktree-docs-login-redirect.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The post-login redirect behavior changed in #183 (merged), but the docs still describe the old behavior. This PR brings the docs in line with the shipped code.
What the code actually does now (
modules/users/users/module.py): whenlogin_redirect_urlis left at its default/dashboard/and the Dashboard module isn't installed, theusersmodule redirects to the first sibling module that exposes view routes (itsview_prefix), only falling back to/as an absolute last resort. Hard-coding/previously 404'd on apps without a root route (e.g.smpy_gis,--preset minimal). Operator-set overrides are always preserved.Changes
docs/modules/users.md— settings table entry forlogin_redirect_urlnow describes the sibling-view fallback instead of the old/fallback.docs/modules/dashboard.md— "Replacing it" section now explains the auto-detect/fallback accurately.CHANGELOG.md— added an[Unreleased] → Fixedentry for the redirect change (Login success redirects to / (404) instead of /dashboard #173), which was not previously recorded.Notes
Docs-only change; no code touched. The original fix (PR #183) is already merged — this is the follow-up documentation that wasn't included at the time.
Refs #173, #183