Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding linter ignores for EDA linters #249

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

alisonlhart
Copy link
Collaborator

@alisonlhart alisonlhart commented Nov 30, 2023

Adding ignores for certain linter tests inside of the EDA tox test. These ignores are added for the following reasons:

Ruff:

  • FA100: Conflicts with ansible-test sanity
  • FA102: Conflicts with ansible-test sanity
  • UP001: Internal test conflict between pylint and ruff
  • UP010: Conflicts with ansible-test sanity
  • I001: Can conflict with ansible-test sanity

Pylint:

  • E0401: Red herring error resulting from how tox builds linter envs
  • C0103: Internal test conflict between pylint and ruff
  • R0913: Unnecessary test

Issue: AAH-2997

@jctanner
Copy link
Collaborator

jctanner commented Dec 6, 2023

@alisonlhart is this ready to merge? Should it maybe have a changelog?

@alisonlhart
Copy link
Collaborator Author

@jctanner Good point, I think it should. I'll add one before merge

@alisonlhart
Copy link
Collaborator Author

@jctanner Changelog added. It's ready to go now.

@jctanner jctanner merged commit 98c7957 into ansible:master Dec 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants